From df6f0808a302cb306b896e722f6790739db97899 Mon Sep 17 00:00:00 2001 From: Piotr Dobrowolski Date: Tue, 28 Aug 2018 14:38:43 +0200 Subject: [PATCH] Log exceptions instead of reraising them in QThread --- luftdaten-tool.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/luftdaten-tool.py b/luftdaten-tool.py index 3c62699..47d702e 100644 --- a/luftdaten-tool.py +++ b/luftdaten-tool.py @@ -6,6 +6,7 @@ import time import tempfile import hashlib import zlib +import logging import serial import serial.tools.list_ports @@ -62,7 +63,8 @@ class QThread(QtCore.QThread): except Exception as exc: if self.error: self.error.emit(str(exc)) - raise + # raise here causes windows builds to just die. ¯\_(ツ)_/¯ + logging.exception('Unhandled exception') class MainWindow(QtWidgets.QMainWindow, mainwindow.Ui_MainWindow): @@ -273,6 +275,7 @@ class MainWindow(QtWidgets.QMainWindow, mainwindow.Ui_MainWindow): if __name__ == "__main__": + logging.basicConfig(level=logging.INFO) app = QtWidgets.QApplication(sys.argv) window = MainWindow(app=app) window.show()